Skip to content

Fix native coroutines dependency #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix native coroutines dependency #107

merged 1 commit into from
Oct 16, 2020

Conversation

@whyoleg
Copy link
Member

@whyoleg whyoleg commented Oct 15, 2020 •
edited
Loading

also minor: update gradle and remove todo.md

@yschimke can you check, that it works for you, without excluding kotlinx from rsocket-kotlin?
(build failed, so not published yet :( )

@whyoleg
fix native coroutines dependency
5731fb4 
update gradle
remove todo
@whyoleg whyoleg added this to the 0.10.0 milestone Oct 15, 2020
@whyoleg whyoleg requested a review from yschimke October 15, 2020 06:42
@whyoleg whyoleg self-assigned this Oct 15, 2020
yschimke
yschimke approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check with either a PR snapshot, or land now and fix forward later. And a big thanks from me.

@whyoleg
Copy link
Member Author

whyoleg commented Oct 15, 2020

Let's wait for build and snapshot publish, and then do real test. BTW, I can do it on my own, if needed (just need to setup rsocket-cli locally).

@yschimke
Copy link
Member

yschimke commented Oct 15, 2020

Let's wait for build and snapshot publish, and then do real test. BTW, I can do it on my own, if needed (just need to setup rsocket-cli locally).

There aren't many good unit tests but io.rsocket.RunMainKt should run straight out of the IDE.

@whyoleg
Copy link
Member Author

whyoleg commented Oct 16, 2020

Checked. Sync - ok, build - ok, run - ok.

@whyoleg whyoleg merged commit 3f79945 into master Oct 16, 2020
@whyoleg whyoleg deleted the task/cleanup-after-native branch October 16, 2020 06:39
@yschimke
Copy link
Member

yschimke commented Oct 16, 2020

Will put up a PR - likely blocked on slow executor https://github.com/rsocket/rsocket-kotlin/runs/1263032155

@whyoleg
Copy link
Member Author

whyoleg commented Oct 16, 2020

I think It should be ok. Build on ubuntu is around 1h 20m because it build an test: jvm, js (legacy and IR) and native linux :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@whyoleg whyoleg

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@whyoleg @yschimke